test: Fix flaky test in TestHoodieClientMultiWriter #17793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PavithranRick
pushed a commit
to PavithranRick/hudi
that referenced
this pull request
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
The test
TestHoodieClientMultiWriter#testMultiWriterWithInsertsToDistinctPartitionsuses hardcoded sequential instant times ("002", "003", "004", "005", "006") for 5 concurrent writers. Since the writers ran concurrently without coordination, there was no guarantee they would start and complete in order. If writer "004" started first, subsequent attempts would create "002" or "003", which is not realistic.Summary and Changelog
This PR fixes the test to use
InProcessTimeGenerator.createNewInstantTime()for the each commit.Impact
Test improvement.
Risk Level
none
Documentation Update
none
Contributor's checklist